fix(server): log upstream 5xx bodies from proxied workspace requests - #40135
Open
jamesmurdza wants to merge 1 commit into
Open
fix(server): log upstream 5xx bodies from proxied workspace requests#40135jamesmurdza wants to merge 1 commit into
jamesmurdza wants to merge 1 commit into
Conversation
A 5xx from a remote workspace sandbox previously passed through the proxy opaquely: the detailed cause was logged only inside the sandbox, so the host tailing its own log saw nothing. Buffer the (small) error body for 5xx responses, log it on the host, and forward it unchanged with its original content-type so the client can still read the structured error ref. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to #39471, #36826
Type of change
What does this PR do?
The workspace proxy streams the upstream response straight through. When a remote sandbox returns a 5xx, the detailed cause is only logged inside the sandbox, so a maintainer tailing the host's log sees nothing — just an error surfacing on the client with no local trace to correlate it against.
For 5xx responses only, this buffers the (small) error body, logs it on the host via
Effect.logErrorwith the url/method/status, and then forwards the body unchanged with its original content-type. Buffering is fine here because these are short error payloads, not streamed content, and preserving the content-type means the client can still parse the structured error (e.g. itsref). Success/2xx responses keep streaming exactly as before.How did you verify your code works?
Screenshots / recordings
N/A — not a UI change.
Checklist