fix(tui): render Windows file:// plugin names correctly in /status - #40132
Open
JasonJason-oy wants to merge 1 commit into
Open
fix(tui): render Windows file:// plugin names correctly in /status#40132JasonJason-oy wants to merge 1 commit into
JasonJason-oy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40131
Type of change
What does this PR do?
On Windows, /status derived the plugin name by splitting the fileURLToPath() result on "/", which does not split backslash paths. The whole path became the "filename" and was truncated at the first dot (e.g. "C:\Users\me" for a plugin under the home directory). This PR splits on both "/" and "" so the last path segment (the plugin file name) is used on every platform. The index.ts fallback (parent directory name) is unchanged.
How did you verify your code works?
Verified the derived names with Node for both path styles:
Checklist