Repository navigation
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mshibuya
marked this pull request as ready for review
September 26, 2026 13:29
Owner
|
Hi @mshibuya, thanks for the PR, but I'd prefer to wait until the 4.0.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CarrierWave 4.0 is in prerelease, and Lockbox refuses to load next to it. This raises the version check to accept 4.x. The CarrierWave extension itself needed no changes: the whole test suite passes on 4.0.0.beta with 267 runs, 0 failures and the same 8 skips as on CarrierWave 3.
The Gemfile asks for ">= 4.0.0.beta", "< 5" rather than "~> 4", so that CI runs against the prerelease. It can become "~> 4" once 4.0.0 is out. The other gemfiles stay on CarrierWave 3 and 2, so those versions are still covered.
This comes from the GitLab upgrade from CarrierWave 1.3 to 4 (https://gitlab.com/gitlab-org/gitlab/-/issues/216067), where Lockbox is what stops the application from booting: it is used by TerraformStateUploader, Ci::PipelineArtifactUploader and Ci::SecureFileUploader. GitLab's specs for those uploaders and their models pass with this change. CarrierWave plans a 4.0.0.rc soon, which GitLab wants to validate against, so a release that accepts 4.x before 4.0.0 is final would help them.