Added regression test for geom_text interactive updates (#345) - #346
Open
ANAMASGARD wants to merge 1 commit into
Open
Added regression test for geom_text interactive updates (#345)#346ANAMASGARD wants to merge 1 commit into
ANAMASGARD wants to merge 1 commit into
Conversation
Minimal chromote test: stable key + duration + showSelected must move rendered geom_text position when clicking geom_tallrect. Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 73.10% 73.10%
=======================================
Files 165 165
Lines 8947 8947
=======================================
Hits 6541 6541
Misses 2406 2406
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geom_textwith a stable D3key,showSelected, and non-zerodurationmust move its rendered position after clicking ageom_tallrect..text()fix on master from regressing ifsetMultilineText()is re-enabled forgeom_text.Closes #345
Local result
test-renderer3-geom-text-interactive-updates.R