Repository navigation
refactor(@angular-devkit/build-angular): remove unused picomatch dependency - #34640
Merged
alan-agius4 merged 1 commit intoNov 3, 2026
Conversation
…ndency The proxy configuration consumer moved to @angular/build in 4ffe07a. Remove the unused direct dependency and Bazel type dependency while retaining picomatch in packages that still use it.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unused picomatch dependency and its corresponding TypeScript types (@types/picomatch) from the build_angular package's package.json and BUILD.bazel files. There are no review comments, and I have no feedback to provide.
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Author
|
Thank you（ありがとう）for reviewing and merging my first contribution to Angular CLI! ※ “ありがとう” means “thank you” in Japanese. |
nagahara-naoki
deleted the
codex/remove-unused-build-angular-picomatch
branch
November 3, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
@angular-devkit/build-angulardeclares a direct dependency onpicomatch, but no longer imports it. Its former proxy configuration consumer moved to@angular/buildin commit 4ffe07a.Issue Number: N/A
What is the new behavior?
Remove the unused direct dependency, its workspace lockfile entry, and the unused Bazel
@types/picomatchdependency. Packages that still usepicomatch, including@angular/buildand@angular-devkit/core, retain their own declarations. This does not claim to remove the transitive package from application installations.Does this PR introduce a breaking change?
Other information
Validation:
pnpm install --frozen-lockfilepassed.pnpm bazel test //packages/angular_devkit/build_angular:test //packages/angular_devkit/build_angular:build_angular_dev-server_test --config=no-shardingpassed (both targets). Unit tests: 97 specs, 0 failures. Dev-server: 134 specs, 0 failures, 35 pending.