Repository navigation
refactor(@angular/cli): remove unused code and exports - #34634
Merged
Merged
Conversation
Remove the `findWorkspaceFile` utility in `utilities/project.ts`, which has been unreferenced since the global configuration handling refactor in 746d0c5, and remove the `export` keyword from eleven symbols that are only referenced within their defining file. None of these are public API: the package declares no `exports` field and has no public API golden.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by removing unnecessary exports from various constants, variables, and functions across multiple files, effectively making them internal to their respective modules. Additionally, an unused utility file containing workspace file resolution logic has been deleted. I have no feedback to provide as there are no review comments.
alan-agius4
added
target: patch
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
findWorkspaceFileutility inutilities/project.ts, which has been unreferenced since the global configuration handling refactor in 746d0c5, and remove theexportkeyword from eleven symbols that are only referenced within their defining file. None of these are public API: the package declares noexportsfield and has no public API golden.