Repository navigation
fix(@angular/cli): default ignoreScripts to true when install options are provided - #34631
Merged
alan-agius4 merged 2 commits intoNov 2, 2026
Merged
Conversation
… are provided
Previously, `PackageManager.install()` used a parameter-level default
`options = { ignoreScripts: true }`, which caused `ignoreScripts` to be
`undefined` whenever any option (such as `ignorePeerDependencies` during
`ng update`) was provided without explicitly specifying `ignoreScripts`.
Similarly, `PackageManager.acquireTempPackage()` did not default
`ignoreScripts` to `true` unless explicitly passed.
Ensure `ignoreScripts` defaults to `true` in both methods unless
explicitly set to `false`.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the PackageManager class to ensure that ignoreScripts defaults to true when destructuring options in both the install and package addition methods. It also introduces unit tests to verify this behavior for the install method. The feedback suggests adding similar unit tests for the acquireTempPackage method to guarantee full test coverage and prevent future regressions.
…options are provided
clydin
approved these changes
Nov 2, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
PackageManager.install()used a parameter-level defaultoptions = { ignoreScripts: true }, which causedignoreScriptsto beundefinedwhenever any option (such asignorePeerDependenciesduringng update) was provided without explicitly specifyingignoreScripts. Similarly,PackageManager.acquireTempPackage()did not defaultignoreScriptstotrueunless explicitly passed.Ensure
ignoreScriptsdefaults totruein both methods unless explicitly set tofalse.