[thekhegay]

PR Checklist

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

Pattern from Angular testing guide

let heroServiceSpy: jasmine.SpyObj<HeroService>;

beforeEach(() => {
  heroServiceSpy = jasmine.createSpyObj('HeroService', ['getHeroes']);
});

is migrated to MockedObject<HeroService> variable and object literal with only getHeroes. Jasmine createSpyObj returns any so it compiled before, after migration tsc fails with

error TS2322: Type '{ getHeroes: Mock<Procedure>; }' is not assignable to type 'MockedObject<HeroService>'.

File is reported as transformed and there is no TODO

What is the new behavior?

When createSpyObj initializes or is assigned to variable annotated with jasmine.SpyObj<T>, literal is cast as MockedObject<T> and type import is added. Declaration is looked up in nearest enclosing block, so svc declared in two describe blocks gets its own type in each. Migrated spec from above passes tsc --strict (TS 6.0, vitest 5.0)

New spec cases cover assignment, initializer and two describe blocks with same name, they fail on main

Does this PR introduce a breaking change?

• Yes
• No

Other information

Cast types members that were not spied as present, same as jasmine.SpyObj<T> with untyped createSpyObj did before migration. Other option is TODO without cast, I went with cast since it keeps migrated tests compiling

[gemini-code-assist]

Code Review

This pull request enhances the Jasmine-to-Vitest refactoring schematic by casting jasmine.createSpyObj calls to MockedObject<T> when they are assigned to or initialize a variable annotated with jasmine.SpyObj<T>. This ensures proper type safety and compatibility with Vitest. The review feedback suggests utilizing the existing getUnwrappedParent utility function instead of manually unwrapping parenthesized expressions to handle other transparent wrappers like non-null assertions or type assertions more robustly.

[alan-agius4]

Thanks for working on this. I left a few inline comments regarding parent unwrapping when a type assertion is already present, handling explicit type arguments on createSpyObj<T>, and union types.