Repository navigation
docs: correct inlineStyle and Karma include option descriptions - #34542
Merged
alan-agius4 merged 1 commit intoOct 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates schema descriptions in the Angular build and schematics packages. Specifically, it modifies the Karma builder schema to document support for both .spec and .test files, and simplifies the description of the inlineStyle option in the application schema. A review comment suggests updating the second bullet point in the Karma builder schema description to refer to a "matching test file" instead of a "matching spec file" to maintain consistency with the first bullet point.
alan-agius4
added
target: patch
The `ng new`/`application` `inlineStyle` description claimed only CSS can be included inline, but the schematic sets `inlineStyleLanguage` for other style languages, so inline Sass and Less work. The Karma `include` description said directories pick up only `.spec` files, but test discovery matches both `.spec` and `.test` files with `.ts` or `.tsx`.
alan-agius4
force-pushed
the
docs/inline-style-and-karma-include
branch
from
October 27, 2026 16:18
b0b36da to
2425175
Compare
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ng new/applicationinlineStyledescription claimed only CSS can be included inline, but the schematic setsinlineStyleLanguagefor other style languages, so inline Sass and Less work. The Karmaincludedescription said directories pick up only.specfiles, but test discovery matches both.specand.testfiles with.tsor.tsx.