ci(docs): deploy docs to Netlify, bump pnpm/action-setup to v6 - #2
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
netlify-cliinstead of GitHub Pages, which was failing with a 404 (Ensure GitHub Pages has been enabled) since Pages is not enabled on this repo. Drops the Pages-specific pieces:pages/id-tokenpermissions, thedeploy-pagesjob, the404.htmlSPA fallback copy, and theDOCS_BASE=/angular-gsap/base path (Netlify serves from the domain root).apps/docs/public/_redirects(/* /index.html 200) as the Netlify SPA fallback; prerendered pages still win because real files are served before redirects.pnpm/action-setupv4 → v6 in both workflows: v5 moved the action to Node 24 (clears the Node 20 deprecation warning), v6 added pnpm 11 support, which this repo uses.effectsrow forprovideGsap.Setup required before the deploy works
The workflow needs two repo secrets:
NETLIFY_AUTH_TOKENandNETLIFY_SITE_ID. Until they exist the deploy step will fail on auth.🤖 Generated with Claude Code