Repository navigation
docs: the outside review plan, checked again against v2.11.0 - #254
Merged
Merged
Conversation
Every open item of docs/analysis/PLANO_REVISAO_EXTERNA.md was checked again on 2026-10-04 against main 8e48cd8 (v2.11.0), in the code and on the bench, and the state columns now say what that found: - finding 12 (a PIN policy change from the web restarts the device) closed with #230 on 2026-10-02: pinAuth lives in CFG_USERS, which left CFG_REBOOT_CLASSES. It was never marked; 56 findings remain, not 57. Finding 33 is half closed by #239: the previews are right, the token list for the alarm line still stops at v22. - the six high findings that need code (1, 8, 9, 20, 25, 65) are all still in the code. Finding 25 is the access point opened by the boot gesture: that path never calls the network's begin( ), so the 15 min timeout, which needs a network name, never applies. - finding 20: telemetry and the alarm line still gate on isNetworkHealthy( ), that is NET_READY; only the Air sends before it. - S1: the 4 MB layout with its own staging is done (#245, #246); of the bench suites only the web one ran on the Pico 2 W (67/0 on the v2.11.0 candidate). - S2: steps 1 to 7 shipped in v2.11.0, with three criteria still to settle: the ~17 s were the ROM's watchdog, replaced by a healthy minute and a 300 s deadline (every bad image came back within six minutes); the interrupted write was measured with a RESET and a cut upload, not a power cut; the 20 cycles were not run. - A-04 marked merged; #189 seen in the v2.11.0 gate (4 of 720 reads); CI runs all nine native suites under the sanitizers; the GitHub description still names only the Pico W. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BniVDEDSHGQgcoqmCRn5um
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/analysis/PLANO_REVISAO_EXTERNA.mdis Living, and its state columns were last checked against v2.9.0. This PR checks every open item again on 2026-10-04 againstmain8e48cd8 (v2.11.0), in the code and on the bench, and writes down what that found. Only that document changes.What changed in the state
pinAuthlives inCFG_USERS, which leftCFG_REBOOT_CLASSESbegin( ), so the 15 min timeout, which needs a network name, never appliesNET_READYwithout an NTP answerisNetworkHealthy( ); only the Air sends beforeNET_READY(F08)setup( )turns off, and the design put a healthy minute and a 300 s deadline in its place (every bad image of steps 5 and 6 came back by itself within six minutes of the apply); an interrupted write was measured with a RESET and a cut upload, not a power cut; the 20 cycles were not runHow each item was checked
WebManager_Calib.cppandSensorManager.cpphave not changed since the triage.AppManager_Panel.cpp, the panel's grant moves the three panel bits without comparing them to the caller's own.DisplayManager_Users.cpp, cancelling the forced PIN entry returns to the Settings menu.NetworkManager.cpp, the AP's timeout requiresstrlen(_ssid) > 0, and the boot's forced-AP branch skipsbegin( ).ConfigApply.hmapspinAuthtoCFG_USERS, andCFG_REBOOT_CLASSEShas not heldCFG_USERSsince 2026-10-02 (feat: accounts apply without a restart, and a session ends with its account (A-08) #230).OTA_AB_RP2350.md.Gates run locally
check_angulo.py,check_readme_numbers.py, andscan_secrets.sh.🤖 Generated with Claude Code
https://claude.ai/code/session_01BniVDEDSHGQgcoqmCRn5um