[WIP] Jetpack XR library update for July '26 by trambui09 · Pull Request #978 · android/snippets

trambui09 · 2026-07-09T21:28:29Z

Jetpack XR library update for July '26

gemini-code-assist

Code Review

This pull request updates various XR and Compose components, including replacing AnchorEntity with AnchorSpace, migrating from transformingMovable/transformingResizable to movable/resizable, updating Card usages to ActionCard, and adopting new animation APIs. Critical feedback includes fixing a runtime ClassCastException in Hands.kt caused by an incorrect this cast inside a coroutine builder, and resolving a scaling issue in SceneCoreEntity.kt where layout dimensions are passed directly as meters instead of being converted using virtualPixelDensity.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-07-09T21:33:25Z

                        val extents = FloatSize2d(
-                            Meter.fromPixel(size.width.toFloat(), density).toM(),
-                            Meter.fromPixel(size.height.toFloat(), density).toM(),
+                            size.width.toFloat(),
+                            size.height.toFloat()
                        )


The size parameter in onLayoutSizeChanged represents the layout dimensions in pixels (or virtual pixels). Directly passing size.width.toFloat() and size.height.toFloat() to FloatSize2d without converting them to meters will result in an extremely large quad (e.g., hundreds or thousands of meters wide/high). You should use the virtualPixelDensity retrieved on line 37 to perform the conversion from pixels to meters.

Suggested change

val extents = FloatSize2d(

Meter.fromPixel(size.width.toFloat(), density).toM(),

Meter.fromPixel(size.height.toFloat(), density).toM(),

size.width.toFloat(),

size.height.toFloat()

)

val extents = FloatSize2d(

virtualPixelDensity.pxToMeters(size.width.toFloat()),

virtualPixelDensity.pxToMeters(size.height.toFloat())

)

The suggest didn't work due to the unresolved reference pxToMeters

kkuan2011 · 2026-07-10T00:52:57Z

 # Use an AndroidX snapshot build.
 # https://androidx.dev/snapshots/builds
-# snapshotVersion=14793336
+ snapshotVersion=15770982


I forget, if we set a snapshot version, does this have impact on other teams?

If other teams were relying on an older snapshot release and the API changing between the publication of a snippet but that's extremely rare. Once the release is ready, we don't really change it, we upgrade the version number. I would say if we uncomment this line, it should be commented back within 2 weeks (Jetpack release cycle)

The intention is that the PR author reverts the change to this file - this change is to help XR team members synchronize on the same snapshot version. When Jetpack goes live, we revert the change to snapshotVersion and merge into main.

vad710 · 2026-07-10T12:12:34Z

 import androidx.xr.runtime.Session
 import androidx.xr.runtime.SessionConfigureSuccess
 import androidx.xr.runtime.math.Pose
-import androidx.xr.scenecore.AnchorEntity


Just to confirm that we are handling this name change properly - is this a breaking change or is AnchorEntity still available and marked as depracated?

It's a breaking change. Any code using the old AnchorEntity class will need to be updated to use AnchorSpace.

vad710 · 2026-07-10T12:13:25Z

-        session.configure(config)
+
        lifecycleScope.launch {
+            val session = (Session.create(context = this@GenerateHandJointData) as SessionCreateSuccess).session


Just for my own understanding, what does the syntax of @GenerateHandJointData do here?

this refers to lifecycleScope given that it's within its block. By putting @GenerateHandJointData, you go one level higher, which is an Activity and it's castable as a `Context

vad710 · 2026-07-10T12:14:30Z

            SubspaceModifier
                .height(824.dp)
                .width(1400.dp)
-                .transformingResizable()


Same question here - how is this deprecation being handled?

Do we have enough changes that we should think about doing a migration guide? Or perhaps a few things we should highlight in the Beta Blog post in August?

I think @amyZepp would be a good person to make that call. What do you think Amy?

vad710 · 2026-07-10T12:16:07Z

-                            Meter.fromPixel(size.width.toFloat(), density).toM(),
-                            Meter.fromPixel(size.height.toFloat(), density).toM(),
+                            size.width.toFloat(),
+                            size.height.toFloat()


is the data we are returning from these values fundamentally different now?

I am trying to understand if we have a sneaky breaking change that might be hard to detect and leading to bugs.

vad710 · 2026-07-10T12:17:21Z

            }
        } else if (isVisualUiSupported) {
-            Card(
+            ActionCard(


This is an interesting API change. Same concerns re depracation.

If the glimmer Card composable has an action parameter, it is a breaking change (which it is in this case). The glimmer Card composable still exists.

vad710

LGTM - left several comments/questions about how we are handling the breaking change and how we might best set developers for success to navigate these changes.

yrezgui · 2026-07-10T12:24:14Z

-        session.configure(config)
+
        lifecycleScope.launch {
+            val session = (Session.create(context = this@GenerateHandJointData) as SessionCreateSuccess).session


this refers to lifecycleScope given that it's within its block. By putting @GenerateHandJointData, you go one level higher, which is an Activity and it's castable as a `Context

yrezgui · 2026-07-10T13:12:22Z

 # Use an AndroidX snapshot build.
 # https://androidx.dev/snapshots/builds
-# snapshotVersion=14793336
+ snapshotVersion=15770982


If other teams were relying on an older snapshot release and the API changing between the publication of a snippet but that's extremely rare. Once the release is ready, we don't really change it, we upgrade the version number. I would say if we uncomment this line, it should be commented back within 2 weeks (Jetpack release cycle)

devbridie · 2026-07-10T13:15:14Z

Moved the PR back to Draft status due to snapshotVersion change - that change is not meant to land in main.

trambui09 added 2 commits July 9, 2026 12:20

uncomment snapshot build id

b3c0922

migrations for snapshot version

f617478

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

fix build issues and addres gemini feedback

bdaf19e

trambui09 marked this pull request as ready for review July 9, 2026 22:02

trambui09 requested review from a team as code owners July 9, 2026 22:02

kkuan2011 reviewed Jul 10, 2026

View reviewed changes

vad710 reviewed Jul 10, 2026

View reviewed changes

vad710 approved these changes Jul 10, 2026

View reviewed changes

yrezgui approved these changes Jul 10, 2026

View reviewed changes

devbridie marked this pull request as draft July 10, 2026 13:13

trambui09 changed the title ~~Jetpack XR library update for July '26~~ [WIP] Jetpack XR library update for July '26 Jul 10, 2026

Uh oh!

Conversation

trambui09 commented Jul 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vad710 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devbridie commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants