Add niap-android-cert-ext and sdp-file-encrypt libraries to niap-cc#58
Add niap-android-cert-ext and sdp-file-encrypt libraries to niap-cc#58KVVat wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces two major security modules: niap-android-cert-ext, which implements strict X.509 certificate validation and secure lifecycle management using the EST protocol, and sdp-file-encrypt, which provides robust file encryption strategies compliant with NIAP MDF PP requirements. The code review identified several critical issues, including a namespace mismatch in NiapCertHelper that prevents configuration loading, sensitive cryptographic key material being logged to Logcat, potential file descriptor leaks in TinkEncryptionProvider, and thread-safety concerns in NiapCertManager. Additionally, optimizations were suggested to prevent performance bottlenecks during binder buffer flushing and to avoid potential null pointer exceptions in NiapCertValidator.
Added new 2 librarariees for NIAP validations.