Skip to content

Permission Teseter update sdk37#57

Open
KVVat wants to merge 14 commits into
android:masterfrom
KVVat:niap-permission-update-sdk37
Open

Permission Teseter update sdk37#57
KVVat wants to merge 14 commits into
android:masterfrom
KVVat:niap-permission-update-sdk37

Conversation

@KVVat
Copy link
Copy Markdown
Contributor

@KVVat KVVat commented May 28, 2026

Here's Permission Tester updates for sdk 37

@KVVat KVVat marked this pull request as draft May 28, 2026 07:38
@KVVat KVVat requested a review from mpgroover May 28, 2026 07:39
@KVVat KVVat marked this pull request as ready for review May 28, 2026 07:39
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Permission Test Tooling and Companion app to support Android 17 / SDK 37 (CinnamonBun). Key changes include upgrading compileSdk and targetSdk to 37, adding several new services and permissions (such as CAPTURE_KEYBOARD, ACCESS_LOCAL_NETWORK, and various BIND_* permissions), implementing CinnamonBun-specific test suites, and introducing instrumentation tests like CaptureKeyboardTest and InjectKeyEventsTest. Feedback from the reviewer highlights several critical issues: a potential NoSuchMethodError on devices below API 33 due to the direct use of stopForeground(int) when minSdk is 28; a major regression in SignatureTestSuite where legacy signature test modules were accidentally removed; thread-safety concerns with receivedKeyCodes in MainActivity being accessed across threads; and multiple potential NullPointerException crashes in exception handling and system service lookups (e.g., CompanionDeviceManager and DevicePolicyManager).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant