Permission Teseter update sdk37#57
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Permission Test Tooling and Companion app to support Android 17 / SDK 37 (CinnamonBun). Key changes include upgrading compileSdk and targetSdk to 37, adding several new services and permissions (such as CAPTURE_KEYBOARD, ACCESS_LOCAL_NETWORK, and various BIND_* permissions), implementing CinnamonBun-specific test suites, and introducing instrumentation tests like CaptureKeyboardTest and InjectKeyEventsTest. Feedback from the reviewer highlights several critical issues: a potential NoSuchMethodError on devices below API 33 due to the direct use of stopForeground(int) when minSdk is 28; a major regression in SignatureTestSuite where legacy signature test modules were accidentally removed; thread-safety concerns with receivedKeyCodes in MainActivity being accessed across threads; and multiple potential NullPointerException crashes in exception handling and system service lookups (e.g., CompanionDeviceManager and DevicePolicyManager).
Here's Permission Tester updates for sdk 37