Staging/fix init cal channel mask - #3469
Open
stefpopa wants to merge 2 commits into
Open
Conversation
When triggering initial calibrations via the 'calibrate' sysfs attribute, the driver unconditionally overwrites the user-configured channel masks (rx, tx, orx) with the profile defaults. This prevents users from running calibrations on specific channels only. For example, setting calibrate_tx_channel_mask to 0x01 (channel 0 only) would be overwritten to 0xFF (all channels) when writing 1 to calibrate. Fix this by only applying the profile defaults when the user hasn't set a custom channel mask (i.e., when the mask is 0). This matches the behavior of the adrv9025 driver. Fixes: 972f2f0 ("iio: trx-rf: Add ADRV9040 support") Signed-off-by: Stefan Popa <stefan.popa@analog.com>
When triggering initial calibrations via the 'calibrate' sysfs attribute, the driver unconditionally overwrites the user-configured channel masks (rx, tx, orx) with the profile defaults. This prevents users from running calibrations on specific channels only. For example, setting calibrate_tx_channel_mask to 0x01 (channel 0 only) would be overwritten to 0xFF (all channels) when writing 1 to calibrate. Fix this by only applying the profile defaults when the user hasn't set a custom channel mask (i.e., when the mask is 0). This matches the behavior of the adrv9025 driver. Fixes: 1b4e2c9 ("iio: trx-rf: Add ADRV903X support") Signed-off-by: Stefan Popa <stefan.popa@analog.com>
stefpopa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
July 31, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
When triggering initial calibrations via the 'calibrate' sysfs attribute, the driver unconditionally overwrites the user-configured channel masks (rx, tx, orx) with the profile defaults. This prevents users from running calibrations on specific channels only.
For example, setting calibrate_tx_channel_mask to 0x01 (channel 0 only) would be overwritten to 0xFF (all channels) when writing 1 to calibrate.
Fix this by only applying the profile defaults when the user hasn't set a custom channel mask (i.e., when the mask is 0). This matches the behavior of the adrv9025 driver.
PR Type
PR Checklist