Skip to content

ASoC: adi: Add porting note about .pcm_construct() - #3440

Open
ukleinek wants to merge 1 commit into
analogdevicesinc:adsp-6.18.31-yfrom
ukleinek:asoc-adi-porting-note
Open

ASoC: adi: Add porting note about .pcm_construct()#3440
ukleinek wants to merge 1 commit into
analogdevicesinc:adsp-6.18.31-yfrom
ukleinek:asoc-adi-porting-note

Conversation

@ukleinek

Copy link
Copy Markdown
Contributor

PR Description

.pcm_construct() went away in v7.1-rc1 and thus needs some adaption to the driver code. Now that I worked out what to do when porting to a newer upstream version, document the findings to help the next person stumbling over that issue.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

.pcm_construct() went away in v7.1-rc1 and thus needs some adaption to
the driver code. Now that I worked out what to do when porting to a
newer upstream version, document the findings to help the next person
stumbling over that issue.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

@nunojsa nunojsa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@ukleinek

ukleinek commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

The (for now) three failed jobs failed due to the modified file not being compiled in the defconfig (Error: assert_compiled: Was not compiled during kernel compilation.). I don't feel this is a relevant criticism for this PR.

@sipraga sipraga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uwe, I don't know what you have planned in the sound card area, but I want to remove the other machine driver we have (sc5xx-asoc-card). If you planned to show any love to that, please reconsider.

Here's a small demo branch where you can see what I had in mind instead (just use simple-audio-card): https://github.com/analogdevicesinc/linux/tree/alvin/adsp/asoc-simple-card

@ukleinek

Copy link
Copy Markdown
Contributor Author

Uwe, I don't know what you have planned in the sound card area, but I want to remove the other machine driver we have (sc5xx-asoc-card). If you planned to show any love to that, please reconsider.

No strong interest. I just ported the 6.18.31-y branch to v7.2-rc3 and did some compile tests.

@sipraga

sipraga commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Uwe, I don't know what you have planned in the sound card area, but I want to remove the other machine driver we have (sc5xx-asoc-card). If you planned to show any love to that, please reconsider.

No strong interest. I just ported the 6.18.31-y branch to v7.2-rc3 and did some compile tests.

OK thanx.

Will you share your v7.2-rc branch with the ports? For my own interest.

@ukleinek

Copy link
Copy Markdown
Contributor Author

Will you share your v7.2-rc branch with the ports? For my own interest.

https://github.com/ukleinek/adi-linux/tree/wip-adsp-6.18.31-y-update-to-7.2-rc3

(Note this is just a work-in-progress tree, don't rely on me to update it in a fast-forward manner (or at all).)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants