Conversation
A skill names its own scripts and data in prose and in code spans, which are not markdown links, so the reference checks never see them. A path written against the source repo's layout resolves only for someone standing in that repo, and is dead in every way a skill is actually installed: vendored into a catalog, copied into an agent's skills directory, or fetched with the CLI. The agent follows it, finds nothing, and improvises, which is why the skill keeps passing its evals. A mention is resolved against the file it is written in, the way a markdown link is, and against the skill root, the way an agent handed a skill folder reads it. Either reaches the file, so only a path that answers to neither is reported, and only when it ends with exactly where the file ships, so what was meant is not in doubt. Signed-off-by: John Lybeck <john.lybeck@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references.path_mentions, which reads path-shaped tokens from raw markdown, andstructure._path_errors, wired intoskill_errorsbeside_required_errors.What it does not flag
Every one of these started as a false positive against real skills and became a rule:
${SKILL_DIR}/scripts/launch.shand similar, where the prefix is stripped and the tail is tested.SKILL.mdappears in install instructions for unrelated trees.evals/, which is test data and never the agent's to read.Reported only when the mention ends with exactly where the file ships, so what was meant is not in doubt.
Test plan
TestPathsASkillWritesAboutItself, one per rule above plus the failing case. Full suite 235 tests, green.Before merging
One published skill currently trips this. Its paths need fixing in the product repo it is federated from rather than in the vendored copy, which a re-import would overwrite. Since consumers pin the harness by tag, merging here does not reach them until a tag is cut and the ref is bumped, so this can land first, but a tag should wait for that fix.