Detect ESXi (VMkernel) in discover_and_write_os_family - #299
Merged
Merged
Conversation
`uname -s` returns "VMkernel" on ESXi (exit 0), which currently falls through to OSFamily.LINUX. Map it to OSFamily.ESXI — mirroring the branch already in inbandmanager.py — so the CLI OS-family detection reaches the ESXi code paths in the in-band collectors. Without this, ESXi hosts are misdetected as Linux and every ESXi collector path is skipped. Add a unit test.
alexandraBara
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uname -sreturns "VMkernel" on ESXi (exit 0), which currently falls through to OSFamily.LINUX. Map it to OSFamily.ESXI — mirroring the branch already in inbandmanager.py — so the CLI OS-family detection reaches the ESXi code paths in the in-band collectors. Without this, ESXi hosts are misdetected as Linux and every ESXi collector path is skipped. Add a unit test.Summary
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist