AmdSmi gpu power mismatch check - #298
Open
jaspals3123 wants to merge 1 commit into
Open
jaspals3123 wants to merge 1 commit into
jaspals3123 wants to merge 1 commit into
Conversation
amd-ansonyim
requested changes
Sep 23, 2026
amd-ansonyim
left a comment
amd-ansonyim
left a comment
Collaborator
There was a problem hiding this comment.
Changes for end user clarity
| expected_power_cap = next(iter(power_caps.values())) | ||
| for gpu, power_cap in power_caps.items(): | ||
| if power_cap != expected_power_cap: | ||
| self._log_event( |
Collaborator
There was a problem hiding this comment.
This will log every time we have a mismatched value. If a node has i.e 8 GPUs and all 8 have different power cap values we'll get this event logged 8 times. Would be more clear if we keep track of all mismatched values and log one event at the end highlighting all mismatches.
| category=EventCategory.PLATFORM, | ||
| description=f"Power cap inconsistency for gpu {gpu}", | ||
| priority=EventPriority.ERROR, | ||
| data={"power_caps": list(power_caps.values())}, |
Collaborator
There was a problem hiding this comment.
Might be better to pass in power_caps itself as a dict to the data, otherwise end user will just see a list of power cap values and not the corresponding GPU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ "name": "GPU power-cap validation", "plugins": { "AmdSmiPlugin": { "collection_args": {}, "analysis_args": { "power": { "power_cap_mismatch_allowed": false } } } } }node-scraper --plugin-configs=/home/jaspals/node-scraper/config.json