gpu memory check - #295
Open
jaspals3123 wants to merge 1 commit into
Open
gpu memory check#295jaspals3123 wants to merge 1 commit into
jaspals3123 wants to merge 1 commit into
Conversation
alexandraBara
requested changes
Sep 23, 2026
| if total_vram is None or free_vram is None: | ||
| self._log_event( | ||
| category=EventCategory.PLATFORM, | ||
| description=f"GPU {metric.gpu} VRAM availability is not available", |
Collaborator
There was a problem hiding this comment.
this sounds odd "availability is not available" :)
| except (TypeError, ValueError): | ||
| self._log_event( | ||
| category=EventCategory.PLATFORM, | ||
| description=f"GPU {metric.gpu} VRAM availability is invalid", |
Collaborator
There was a problem hiding this comment.
make this more descriptive, like "was not able to parse available blabla form blabla"
| ) | ||
| continue | ||
|
|
||
| if total_value <= 0: |
Collaborator
There was a problem hiding this comment.
how is this ever going to happen? this seems like something we should check for before we try and compute it in such a way that it gives negative values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new analyzer arg minimum_available_percent
Plugin config:
cmd:
node-scraper --plugin-configs=/home/jaspals/node-scraper/plugin.json