Repository navigation
fix: enforce query row ceiling and preserve routing errors - #123
Merged
Merged
Conversation
Reject SQL host requests and operation policies above 10,000 rows. Preserve intentional MessageRoutingError failures during router input validation while normalizing unexpected errors. Document the shared row ceiling. Verification was explicitly skipped at the user's request.
utay
approved these changes
Oct 28, 2026
albert20260301
approved these changes
Oct 28, 2026
albert20260301
left a comment
There was a problem hiding this comment.
This makes operation declarations and the shared SQL host enforce the same 10,000-row ceiling. Oversized SQL requests are rejected before authorization or backend execution; exactly 10,000 rows remain valid. Intentional input-validation routing errors retain their code, message, and request ID, while unexpected parser failures remain generic.
I verified those boundaries with three additional local probes alongside the existing message/operation tests (23 tests passed). Build, types, lint, package-boundary and reference checks pass; required CI is green. No blocking findings. A published SDK release is still needed for consumers to receive this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted data apps reject requests above 10,000 rows, while shared SDK validation and SQL hosts previously allowed them. Enforce the same ceiling in operation policies and the shared SQL host handler before query execution, using one
MAX_QUERY_ROWSconstant.Preserve intentional
MessageRoutingErrorfailures from input validation so their code, message, and request ID reach callers. Unexpected errors still receive the generic invalid-payload message. Document the row ceiling in the contract guide.Tests and local verification were explicitly skipped at the user's request.