Repository navigation
fix(release): prepare release PRs after draft publication - #166
Merged
Merged
Conversation
Release Please cannot resolve the manifest baseline until a draft release is published and its Git tag exists. Creating the next PR immediately after drafting a release scans the full history and proposes a spurious version bump. Split release creation from PR generation, wait for successful publication, and check the current manifest tag before generating PRs on ordinary pushes or recovery runs. API failures remain visible rather than masquerading as missing tags. Verify the workflow dependency contract and execute its baseline guard against published, missing, and failed API responses.
robinvrd
approved these changes
Oct 20, 2026
francoischalifour
pushed a commit
that referenced
this pull request
Oct 21, 2026
🤖 I have created a release *beep* *boop* --- ## [1.13.1](v1.13.0...v1.13.1) (2026-10-21) ### Bug Fixes * **app:** keep TypeScript out of CLI release bundles ([#167](#167)) ([dc8fb6b](dc8fb6b)) * **release:** prepare release PRs after draft publication ([#166](#166)) ([58b23a2](58b23a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Separate draft release creation from release PR generation. Prepare the next PR only after successful publication, and require the current manifest version's Git tag before generating PRs on ordinary pushes or recovery runs.
Why
Release Please created #164 immediately after drafting v1.13.0, before its Git tag existed. It could not resolve the manifest baseline, scanned the entire history, and proposed a spurious v1.14.0 release containing already-released changes.
Keep releases as drafts while their binaries are verified and uploaded, then generate PRs once the baseline tag is available. Missing tags defer PR generation; GitHub API failures fail the job.
Validation
./scripts/verify.shactionlint .github/workflows/release-please.ymlChecklist
CHANGELOG.mdupdated (skipped: CI-only change)BREAKING CHANGE: …) and changelog (not applicable)