Repository navigation
Target .NET 10 and .NET 11, drop .NET 8/9 - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the library to
net10.0+net11.0and dropsnet8.0/net9.0.Target frameworks
Directory.Build.props:DefaultTargetFrameworkschanged tonet10.0;net11.0. TheAltaSoft.Choicepackage now shipslib/net10.0andlib/net11.0.AltaSoft.Choice.Generatoris unchanged (netstandard2.0).AltaSoft.Choice.Generator.SnapshotTests: now multi-targetsnet10.0;net11.0.AltaSoft.ChoiceGenerator.Tests: moved fromnet10.0tonet11.0only.Why
AltaSoft.ChoiceGenerator.Testsis single-targetThe project uses
Microsoft.XmlSerializer.Generator(SGEN) to pre-generate serializers. The package runs as a legacyDotNetCliToolReferencetool, which thedotnetCLI can't resolve in multi-targeted projects. With multiple target frameworks, SGEN fails on every framework and only reports a build warning, while the tests still pass becauseXmlSerializerfalls back to runtime generation. Keeping the project on a single framework (net11.0) keeps the SGEN step working.Package versions (
Directory.Packages.props)Microsoft.XmlSerializer.Generator10.0.12 → 11.0.0Microsoft.NET.Test.Sdk18.10.0 → 18.11.1xunit.runner.visualstudio4.0.0 → 4.0.1coverlet.collector10.0.1 → 10.1.0Microsoft.CodeAnalysis.*is already on the latest version (5.9.0).Tests
dotnet build: 0 errors. No new warnings; the same 17 warnings asmain(IDE0005 / CS0618 in tests).AltaSoft.ChoiceGenerator.XmlSerializers.dllis generated (SGEN succeeds).dotnet test: all passing. ChoiceGenerator.Tests 117 onnet11.0; SnapshotTests 7 on each ofnet10.0andnet11.0.Docs