Skip to content

Prevent excluded Behave steps from leaking into results (fixes #902) #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuyaohui666 wants to merge 1 commit into
base: master
Choose a base branch
from
+40 −1
Open

Prevent excluded Behave steps from leaking into results (fixes #902) #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions allure-behave/src/listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def stop_scenario(self, scenario):
should_drop_excluded = self.hide_excluded and (scenario.skip_reason == TEST_PLAN_SKIP_REASON or not should_run)

if should_drop_skipped_by_option or should_drop_excluded:
self.steps.clear()
self.logger.drop_test(self.current_scenario_uuid)
else:
status = scenario_status(scenario)
Expand Down
40 changes: 39 additions & 1 deletion tests/allure_behave/acceptance/behave_support/behave_cmd/behave_cmd_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from hamcrest import assert_that, all_of, not_
from tests.allure_behave.behave_runner import AllureBehaveRunner
from allure_commons_test.report import has_test_case
from allure_commons_test.result import with_status
from allure_commons_test.result import has_title, with_status, with_steps


def test_behave_tags_filter(docstring: str, behave_runner: AllureBehaveRunner):
Expand Down Expand Up @@ -62,3 +62,41 @@ def test_behave_no_skipped_support(docstring: str, behave_runner: AllureBehaveRu
)
)
)


def test_hidden_tag_excluded_scenario_steps_are_not_reported(
docstring: str,
behave_runner: AllureBehaveRunner
):
"""Feature: Behave hidden tag-excluded scenario support

Scenario: Scenario without tag
Given an excluded step

@tag
Scenario: Scenario with tag
Given an included step
"""
behave_runner.run_behave(
feature_literals=[docstring],
step_literals=[
"given('an excluded step')(lambda c:None)\n"
"given('an included step')(lambda c:None)"
],
options=["--tags=tag", "-D", "AllureFormatter.hide_excluded=True"]
)
assert_that(
behave_runner.allure_results,
all_of(
not_(
has_test_case("Scenario without tag")
),
has_test_case(
"Scenario with tag",
with_status("passed"),
with_steps(
has_title("Given an included step")
)
)
)
)
Loading