[codex] Fix ROS selling pipeline and A2A compatibility issues#140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR collects a set of fixes for IaC Code pipeline/runtime behavior, with the main focus on making the Alibaba Cloud ROS selling pipeline more deterministic and easier for LLMs to drive safely.
The branch addresses several production-facing issues found during interactive testing:
TemplateBodyor raw ROS stack APIs even when the intended flow requiredTemplateURL.grepbehavior differed between environments with and without ripgrep when symlinked directories were present.Major Changes
Runtime Prompt Context
ROS TemplateURL Enforcement and Dedicated Pipeline Tools
ros_validate_templateros_preview_stackros_get_template_parameter_constraintsaliyun_apiavailable for other cloud-product calls.TemplateBodyfor ROS selling-pipeline calls.Selling Pipeline Deployment Flow
ros_deployfor the selling deployment step and removes directros_stackusage from that step.continue_create:<stack_id>for continuing a failed stack create.delete_and_create:<stack_id>for deleting/recreating a stack created by the current selling deployment step.ContinueCreateStackwithRecreatingOptions: ["AutoRecreatingResources"], while still allowing delete-and-create fallback for owned stacks when needed.ros_deploy_owned_stack_idsduring fresh complete-step recovery, preventing recovered deployment attempts from losing stack ownership state.Deployment Fast Path After Preview
ValidateTemplate/preview calls when the selected template has already passed preview validation.Template Generation and CIDR Guardrails
templates/directory manually during template generation.CidrBlockvalues when an existing VPC is selected.A2A Path Redaction and Debugging
text_deltastreaming is not rewritten in a way that would break streaming output.Bundled Skill References and Packaging
references/directory that mostly uses symlinks to existing bundled Alibaba Cloud references, with onlytemplate-parameter-recommendation.mdcustomized for the selling pipeline.read_file,glob,grep, andlist_filesbehavior/tests around symlinked references and trusted roots.grepto fall back to the Python implementation when the search tree contains directory symlinks, avoiding inconsistent ripgrep behavior and preserving allowed-root filtering.i18n and UI Labels
Compatibility Notes
Validation
Local validation completed before opening this PR:
make lintmake test(7997 passed, 1 skipped)The pre-push hook also completed AK leak detection without finding data to scan.
Review Focus
Please pay special attention to:
CreateStack/ContinueCreateStackflows.