Skip to content

fix(cli): prepare failed setup retries - #539

Merged
alongubkin merged 1 commit into
mainfrom
alon/alien-615-resume-failed-setup-refresh
Aug 30, 2026
Merged

fix(cli): prepare failed setup retries#539
alongubkin merged 1 commit into
mainfrom
alon/alien-615-resume-failed-setup-refresh

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

Prepare a fresh direct setup target before retrying deployments in initial-setup-failed or provisioning-failed. The generated CLI already detects these states and acquires the setup run; this change prevents the shared runner from immediately treating the reacquired failed status as terminal.

Setup-owned infrastructure remains reconciled by the generated setup flow, and runtime IAM mutation remains removed.

Test

  • cargo test -p alien-deploy-cli failed_setup_states_are_prepared_before_retrying -- --nocapture
  • cargo fmt --check -p alien-deploy-cli

@alongubkin
alongubkin merged commit 9b355bb into main Aug 30, 2026
23 checks passed
@alongubkin
alongubkin deleted the alon/alien-615-resume-failed-setup-refresh branch August 30, 2026 19:13
@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Greptile Summary

This PR prepares direct setup state before retrying deployments in initial-setup-failed or provisioning-failed, preventing the shared runner from immediately treating the reacquired status as terminal.

  • Extracts the direct-setup preparation status predicate into requires_direct_setup_preparation.
  • Adds the two failed setup states to that predicate.
  • Adds regression coverage for statuses that do and do not require preparation.

Confidence Score: 5/5

The PR appears safe to merge with no concrete actionable failures identified.

The failed setup states now follow the existing preparation path, which rebuilds setup metadata and resets the state before the setup loop evaluates terminal statuses; the normal failure producers preserve the state required by this path.

Important Files Changed

Filename Overview
crates/alien-deploy-cli/src/commands/up.rs Extends direct setup preparation to failed initial-setup and provisioning retries and adds focused status-classification coverage.

Reviews (1): Last reviewed commit: "fix(cli): prepare failed setup retries" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant