fix(cli): prepare failed setup retries - #539
Merged
Merged
Conversation
Greptile SummaryThis PR prepares direct setup state before retrying deployments in
Confidence Score: 5/5The PR appears safe to merge with no concrete actionable failures identified. The failed setup states now follow the existing preparation path, which rebuilds setup metadata and resets the state before the setup loop evaluates terminal statuses; the normal failure producers preserve the state required by this path.
|
| Filename | Overview |
|---|---|
| crates/alien-deploy-cli/src/commands/up.rs | Extends direct setup preparation to failed initial-setup and provisioning retries and adds focused status-classification coverage. |
Reviews (1): Last reviewed commit: "fix(cli): prepare failed setup retries" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare a fresh direct setup target before retrying deployments in
initial-setup-failedorprovisioning-failed. The generated CLI already detects these states and acquires the setup run; this change prevents the shared runner from immediately treating the reacquired failed status as terminal.Setup-owned infrastructure remains reconciled by the generated setup flow, and runtime IAM mutation remains removed.
Test
cargo test -p alien-deploy-cli failed_setup_states_are_prepared_before_retrying -- --nocapturecargo fmt --check -p alien-deploy-cli