Skip to content

fix(cli): refresh setup before failed retries - #538

Merged
alongubkin merged 2 commits into
mainfrom
alon/alien-613-refresh-failed-setup-retries
Aug 30, 2026
Merged

fix(cli): refresh setup before failed retries#538
alongubkin merged 2 commits into
mainfrom
alon/alien-613-refresh-failed-setup-retries

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • reconcile a newer generated setup revision before retrying deployments in initial-setup-failed or provisioning-failed
  • keep the existing once-per-package-revision behavior
  • replace customer-specific endpoint fixtures with neutral example domains

Tests

  • cargo test -p alien-deploy-cli commands::up::tests::hosted_setup_reconciles_each_packaged_revision_once -- --exact
  • cargo test -p alien-core machine_public_endpoints_round_trip_without_rewriting_urls

@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Greptile Summary

This PR allows hosted setup reconciliation and setup-run acquisition for newer packaged revisions when deployments are in initial-setup-failed or provisioning-failed.

  • Extends failed-state eligibility in the hosted setup reconciliation gate.
  • Adds provisioning-failed to setup-run acquisition statuses.
  • Expands regression coverage for both failed states.
  • Replaces customer-specific endpoint fixtures with neutral example domains.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported failed-state acquisition issues are addressed by the expanded client status list and the documented hosted setup-run acquisition contract.

Important Files Changed

Filename Overview
crates/alien-deploy-cli/src/commands/up.rs Extends hosted setup reconciliation eligibility to initial-setup and provisioning failure states while preserving revision deduplication.
crates/alien-deployment/src/manager_api_transport.rs Centralizes setup-run acquisition statuses and adds provisioning-failed with focused regression coverage.
crates/alien-core/src/stack_settings.rs Replaces customer-specific public endpoint test values with neutral example domains without changing production behavior.

Sequence Diagram

sequenceDiagram
    participant U as alien-deploy up
    participant C as Hosted setup gate
    participant M as Manager API
    U->>C: Compare packaged and applied setup revisions
    alt Newer packaged revision in supported failed state
        C-->>U: Reconciliation required
        U->>M: Acquire setup-run deployment with failed status
        M-->>U: Deployment lock and state
        U->>M: Reconcile setup revision
    else Revision already applied
        C-->>U: Preserve once-per-revision behavior
    end
Loading

Reviews (4): Last reviewed commit: "fix: acquire failed provisioning for set..." | Re-trigger Greptile

Comment thread crates/alien-deploy-cli/src/commands/up.rs
@alongubkin

Copy link
Copy Markdown
Member Author

The companion Platform recovery prerequisite is now merged as alienplatform/platform@c8859762acd5937cfef24cefac9a6ac84157a2c2 (PR #533). It adds explicit setup-run recovery from provisioning-failed while preserving the runtime retry gate, and prevents stale prepared-stack replay when a corrective release changed the desired release. Exact-head Platform CI and Greptile review are fully green. Please re-review this PR against that merged prerequisite.

@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai please re-review the current head against the now-merged Platform prerequisite linked above.

Comment thread crates/alien-deploy-cli/src/commands/up.rs
@alongubkin
alongubkin enabled auto-merge (squash) August 30, 2026 15:54
@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai please re-review. The two stale findings are resolved with the exact merged Platform server contract and Alien client status fix documented in-thread.

@alongubkin
alongubkin merged commit 3fab2a9 into main Aug 30, 2026
23 of 24 checks passed
@alongubkin
alongubkin deleted the alon/alien-613-refresh-failed-setup-retries branch August 30, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant