fix(cli): refresh setup before failed retries - #538
Conversation
Greptile SummaryThis PR allows hosted setup reconciliation and setup-run acquisition for newer packaged revisions when deployments are in
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported failed-state acquisition issues are addressed by the expanded client status list and the documented hosted setup-run acquisition contract.
|
| Filename | Overview |
|---|---|
| crates/alien-deploy-cli/src/commands/up.rs | Extends hosted setup reconciliation eligibility to initial-setup and provisioning failure states while preserving revision deduplication. |
| crates/alien-deployment/src/manager_api_transport.rs | Centralizes setup-run acquisition statuses and adds provisioning-failed with focused regression coverage. |
| crates/alien-core/src/stack_settings.rs | Replaces customer-specific public endpoint test values with neutral example domains without changing production behavior. |
Sequence Diagram
sequenceDiagram
participant U as alien-deploy up
participant C as Hosted setup gate
participant M as Manager API
U->>C: Compare packaged and applied setup revisions
alt Newer packaged revision in supported failed state
C-->>U: Reconciliation required
U->>M: Acquire setup-run deployment with failed status
M-->>U: Deployment lock and state
U->>M: Reconcile setup revision
else Revision already applied
C-->>U: Preserve once-per-revision behavior
end
Reviews (4): Last reviewed commit: "fix: acquire failed provisioning for set..." | Re-trigger Greptile
|
The companion Platform recovery prerequisite is now merged as alienplatform/platform@c8859762acd5937cfef24cefac9a6ac84157a2c2 (PR #533). It adds explicit setup-run recovery from provisioning-failed while preserving the runtime retry gate, and prevents stale prepared-stack replay when a corrective release changed the desired release. Exact-head Platform CI and Greptile review are fully green. Please re-review this PR against that merged prerequisite. |
|
@greptileai please re-review the current head against the now-merged Platform prerequisite linked above. |
|
@greptileai please re-review. The two stale findings are resolved with the exact merged Platform server contract and Alien client status fix documented in-thread. |
Summary
Tests
cargo test -p alien-deploy-cli commands::up::tests::hosted_setup_reconciles_each_packaged_revision_once -- --exactcargo test -p alien-core machine_public_endpoints_round_trip_without_rewriting_urls