fix(aws): keep compute role policy setup-owned - #536
Merged
alongubkin merged 1 commit intoAug 30, 2026
Conversation
Greptile SummaryThis PR restores setup ownership of the AWS compute VM role policy by removing inline-policy mutation authority from compute-cluster management.
Confidence Score: 5/5The PR appears safe to merge based on the repository-local permission contract and regression coverage. The changed permission set consistently removes both inline role-policy mutation actions, and the runtime and CloudFormation tests enforce the intended setup-ownership boundary without introducing a demonstrated repository-local failure.
|
| Filename | Overview |
|---|---|
| crates/alien-permissions/permission-sets/compute-cluster/management.jsonc | Removes management authority to mutate inline policies on setup-created compute roles, with no repository-local caller shown to require it. |
| crates/alien-permissions/tests/aws_cloudformation.rs | Replaces the positive role-policy mutation assertion with a regression asserting that generated CloudFormation management policies contain neither mutation action. |
| crates/alien-permissions/tests/aws_runtime.rs | Replaces the positive runtime grant assertion with a regression asserting that runtime management policies contain neither mutation action. |
Reviews (1): Last reviewed commit: "fix(aws): keep compute role policy setup..." | Re-trigger Greptile
alongubkin
deleted the
alon/alien-613-remove-runtime-role-policy-writes
branch
August 30, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo nextest run -p alien-permissions --test aws_runtime --test aws_cloudformation