fix(aws): allow compute role policy reconciliation - #532
Merged
Conversation
Greptile SummaryThe PR grants the compute-cluster management controller narrowly scoped permission to update and delete inline policies on setup-created AWS compute roles.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/alien-permissions/permission-sets/compute-cluster/management.jsonc | Adds inline-policy reconciliation permissions using a role-specific stack-prefix pattern that no longer includes the management role identified by the prior thread. |
| crates/alien-permissions/tests/aws_cloudformation.rs | Verifies CloudFormation generation includes both IAM actions and the narrowed role ARN pattern. |
| crates/alien-permissions/tests/aws_runtime.rs | Verifies runtime generation includes both IAM actions and the narrowed role ARN pattern. |
Reviews (2): Last reviewed commit: "fix(aws): narrow compute role policy sco..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Capacity updates reconcile the node execution policy before changing the fleet. The generated management role already owns fleet reconciliation, but lacked the IAM actions required for this narrow step, causing AWS updates to fail before reaching the ASG.
Verification