Skip to content

describe ends every statement with ';' and never emits '/' (valid under mdl 0 and mdl 1) #744

Description

@ako

Part of plan item 2.6 (canonical describe, ADR-0010 R11 and R12). This blocks #741 (strict parsing), whose mdl 1 rules reject what describe prints today:

  • About 20 document types end with a SQL*Plus / line (emitted in 15 files: agents, knowledge bases, MCP services, models, constants, contracts, associations, DB connections, entities, enumerations, image collections, modules, OData, published REST, security).
  • Pages, snippets and layouts end with a bare } and no ;.

As a result, tests that run describe output under mdl 1 fail as soon as #741 is combined with #737 and #740, for example TestPedAppListActivitiesUnderMdl1 and TestPedAppRoundTrip_RetrieveRange.

Scope

  • Every statement describe emits ends with ;, and no / line is emitted, for every document type. Blank lines between statements are fine. The output must be valid under both mdl 0 (where ; was always accepted) and mdl 1.
  • Update the tests that assert the old / or unterminated output.
  • Check the round-trip test (go test -tags integration ./mdl/roundtrip/). The allowlist may only shrink.
  • Add a test that runs every document type's describe output from PedApp through the mdl 1 parser and expects no strictness errors. It must fail on today's output.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions