Restore User-Agent for superagent@10 login compatibility (v1.1.8) - #29
Open
baraka-akeyless wants to merge 3 commits into
Open
Restore User-Agent for superagent@10 login compatibility (v1.1.8)#29baraka-akeyless wants to merge 3 commits into
baraka-akeyless wants to merge 3 commits into
Conversation
v1.1.7 forced superagent@10 for the url.parse fix, but that client no longer sends a default User-Agent. Some Gateway/WAF setups reject those requests as Failed to login to Akeyless; restore the v1.1.6-compatible UA on ApiClient default headers. Co-authored-by: Cursor <cursoragent@cursor.com>
AWS IAM cloud-id failures and API auth errors are now included in setFailed so self-hosted test runs show the root cause without enabling debug. Co-authored-by: Cursor <cursoragent@cursor.com>
Smithy SignatureV4 caused SignatureDoesNotMatch when Akeyless replayed GetCallerIdentity; match akeyless-cloud-id's aws4 header layout while keeping AWS SDK v3 credentials and superagent@10. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
superagent@10.3.0(forced in v1.1.7 to fixurl.parseDEP0169) sends noUser-Agent, whilesuperagent@3.7.0always sentnode-superagent/3.7.0.Failed to login to Akeylesson configs that worked on v1.1.6.User-Agent: node-superagent/3.7.0 akeyless-github-actionon ApiClientdefaultHeaders(keeps superagent@10 / no DEP0169).v1.1.8.Test plan
npm test(34 tests, including new HTTP capture asserting User-Agent is sent)npm run package@fix/restore-user-agent-superagent10or@v1.1.8after releaseMade with Cursor