feat(browser): mark finished items with a check cap, not a thick bar - #955
Merged
Merged
Conversation
Issue 856 feedback: the 6px grey finished bar was hard to tell from the 3px reading bar when scanning a grid, and only really read when two cards sat side by side. The dimmed caption was a second cue that made read titles harder to read. Every bar is now 3px. A finished comic or all-read collection ends its bar in a 10px grey check circle, the same grey as the fill. The bar runs under the cap to its centre so the two join with no gap. The check is stroked in the page background instead of cut out, because a cut-out would show the track through it. The fill is still the real bookmark position, so a comic marked read but never opened is an empty track and its cap. Read titles and subtitles keep their normal colour. The bar is now one component, ReadStateBar, used by both the browser card and the metadata dialog. They had duplicated its CSS, and the cap would have been a third copy to keep in sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The read state bar in the metadata dialog has been invisible since the read state landed in v2.4.0. It sat 15px up over the cover's bottom edge, where the old v-progress-linear used to be. That component is positioned, so it painted over the cover. The plain div that replaced it is not, and the absolutely positioned cover image painted over the bar. It now sits 1px under the cover at every breakpoint, as on the browser card, which moves the dialog's buttons down about 16px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #856.
Alfons' feedback on the v2.4.0 read state: the 6px grey finished bar is hard to tell from the 3px reading bar when you scan a grid of covers.
Changes
ReadStateBar(frontend/src/components/read-state-bar.vue) now draws the bar for both the browser card and the metadata dialog. They had duplicated its CSS.Testing
make lintpasses.make test-frontendpasses 940 tests, including the newread-state-bar.test.js.🤖 Generated with Claude Code