Skip to content

Fix integration tests - #1185

Merged
Dreamsorcerer merged 2 commits into
aio-libs:masterfrom
GeorgeHarland:georgeh/fix-integration-tests
Aug 4, 2026
Merged

Fix integration tests#1185
Dreamsorcerer merged 2 commits into
aio-libs:masterfrom
GeorgeHarland:georgeh/fix-integration-tests

Conversation

@GeorgeHarland

Copy link
Copy Markdown
Contributor

What do these changes do?

Fixes the integration tests for issue #934:

  • 3 tests were broken by an old @testing-library/dom / React Testing Library version mismatch. This has since been fixed in a later dependency bump so this merge just removes the early returns.
  • The bulk update test in permissions.test.js was failing because BulkUpdateButton doesn't refresh on success in pessimistic mode so the list never reflected the update. This merge adds an explicit useRefresh() call to fix it.
    • I think a previous dependency mismatch may have hidden the issue rather than broken the test as such.

Are there changes in behavior for the user?

Yes. Bulk updates now refresh the list after completion so users will see updated values immediately instead of potentially stale data.

Related issue number

Fixes #934

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.76%. Comparing base (981929d) to head (f6df1a5).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
+ Coverage   95.63%   95.76%   +0.13%     
==========================================
  Files          21       21              
  Lines        2954     2955       +1     
  Branches      199      200       +1     
==========================================
+ Hits         2825     2830       +5     
+ Misses        103      100       -3     
+ Partials       26       25       -1     
Flag Coverage Δ
integration 81.24% <100.00%> (+0.42%) ⬆️
js 83.96% <100.00%> (+0.06%) ⬆️
unit 97.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeorgeHarland GeorgeHarland changed the title Georgeh/fix integration tests Fix integration tests Aug 4, 2026
@Dreamsorcerer

Copy link
Copy Markdown
Member

Any chance you know how to get it working with vitest? #963

@Dreamsorcerer

Copy link
Copy Markdown
Member

Curious what changed for that to fail in the first place, but I'll merge this in for now. Thanks for looking at it.

@Dreamsorcerer
Dreamsorcerer merged commit ef6fc55 into aio-libs:master Aug 4, 2026
13 checks passed
@GeorgeHarland

Copy link
Copy Markdown
Contributor Author

Any chance you know how to get it working with vitest? #963

I'll have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken tests

2 participants