refactor(cli): name the MCP launch-command transform after what it does - #836
Merged
Merged
Conversation
`tools/domain/mcp-exclusion.ts` holds only `transformFor`, the transform of an MCP server's launch command for the target platform. The exclusion it was named for was deleted with #816, so the name pointed at a feature that no longer exists. The module becomes `mcp-launch-command.ts`, with its test file, its one import and its entry in the context-boundary public-module list. No behaviour change. Fixes #824 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011x4ms5qcGuZgYhCxfdHMUb AIDD-Session-Id: 4acc9a1c-19bc-4468-b8b6-e86644bcba60
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
cli/src/contexts/tools/domain/mcp-exclusion.tsnow holds onlytransformFor: the Windows transform of an MCP server's launch command (npx→cmd /c npx,uvx→uvx.exe,uv→uv.exe). The MCP exclusion it was named for was deleted by #816. The file name pointed a reader at a feature that no longer exists, against the repository's rule to name by intention, not by history (#824).🛠️ How it works
A pure rename, with no behaviour change:
src/contexts/tools/domain/mcp-exclusion.ts→mcp-launch-command.ts;tests/contexts/tools/domain/mcp-exclusion.unit.test.ts→mcp-launch-command.unit.test.ts;install-config-use-case.ts;toolspublic-module list oftests/architecture/context-boundary.arch.test.ts.git mvkeeps both files' history. The function nametransformForis unchanged: the module name now says what it transforms.🧪 How to verify
context-boundary.arch.test.tsfailed withinstall-config-use-case.ts -> src/contexts/tools/domain/mcp-launch-command.ts, a cross-context import to an undeclared module. It passes once the list names the new module.grep -rn mcp-exclusion cli/src cli/testsfinds nothing.Local results:
nextsrc/4471,tests/2987, unchangedcli/CHANGELOG.mdand the dated task documents underaidd_docs/tasks/still saymcp-exclusion. They are history, left as written.🔗 Linked issue
Fixes #824
✅ I certify
🤖 Generated with Claude Code
https://claude.ai/code/session_011x4ms5qcGuZgYhCxfdHMUb