Skip to content

refactor(cli): name the MCP launch-command transform after what it does - #836

Merged
blafourcade merged 1 commit into
nextfrom
refactor/name-mcp-launch-command-transform
Sep 11, 2026
Merged

refactor(cli): name the MCP launch-command transform after what it does#836
blafourcade merged 1 commit into
nextfrom
refactor/name-mcp-launch-command-transform

Conversation

@blafourcade

Copy link
Copy Markdown
Contributor

🎯 What & why

cli/src/contexts/tools/domain/mcp-exclusion.ts now holds only transformFor: the Windows transform of an MCP server's launch command (npxcmd /c npx, uvxuvx.exe, uvuv.exe). The MCP exclusion it was named for was deleted by #816. The file name pointed a reader at a feature that no longer exists, against the repository's rule to name by intention, not by history (#824).

🛠️ How it works

A pure rename, with no behaviour change:

  • src/contexts/tools/domain/mcp-exclusion.tsmcp-launch-command.ts;
  • tests/contexts/tools/domain/mcp-exclusion.unit.test.tsmcp-launch-command.unit.test.ts;
  • the one import, in install-config-use-case.ts;
  • the module's entry in the tools public-module list of tests/architecture/context-boundary.arch.test.ts.

git mv keeps both files' history. The function name transformFor is unchanged: the module name now says what it transforms.

🧪 How to verify

  • Red first: with the file renamed and the public-module list not yet updated, context-boundary.arch.test.ts failed with install-config-use-case.ts -> src/contexts/tools/domain/mcp-launch-command.ts, a cross-context import to an undeclared module. It passes once the list names the new module.
  • grep -rn mcp-exclusion cli/src cli/tests finds nothing.

Local results:

Check Result
typecheck, lint, knip, type honesty pass
architecture 128 passed
unit + integration 5784 passed, the same count as next
comment lines src/ 4471, tests/ 2987, unchanged

⚠️ Heads-up

  • cli/CHANGELOG.md and the dated task documents under aidd_docs/tasks/ still say mcp-exclusion. They are history, left as written.
  • The manifest test "a manifest written while the CLI still recorded MCP exclusions" is about an old manifest format, not this module, and stays.

🔗 Linked issue

Fixes #824

✅ I certify

  • I DO CERTIFY I READ EACH LINE OF THE PULL REQUEST BECAUSE I AM A SOFTWARE ENGINEER, NOT A AI PUPPY.

🤖 Generated with Claude Code

https://claude.ai/code/session_011x4ms5qcGuZgYhCxfdHMUb

`tools/domain/mcp-exclusion.ts` holds only `transformFor`, the transform of an
MCP server's launch command for the target platform. The exclusion it was
named for was deleted with #816, so the name pointed at a feature that no
longer exists. The module becomes `mcp-launch-command.ts`, with its test file,
its one import and its entry in the context-boundary public-module list.
No behaviour change.

Fixes #824

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011x4ms5qcGuZgYhCxfdHMUb
AIDD-Session-Id: 4acc9a1c-19bc-4468-b8b6-e86644bcba60
@blafourcade
blafourcade requested a review from a team as a code owner September 11, 2026 02:57
@blafourcade
blafourcade merged commit 468a6fd into next Sep 11, 2026
25 checks passed
@blafourcade
blafourcade deleted the refactor/name-mcp-launch-command-transform branch September 11, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant