-
Notifications
You must be signed in to change notification settings - Fork 38
feat(aidd-vcs): add conflict resolution skill #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexsoyes
wants to merge
3
commits into
next
Choose a base branch
from
codex/resolve-conflict-skill
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
aidd_docs/tasks/2026_09/2026_09_02_resolve-conflict-skill/review.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Review: Resolve conflict skill | ||
|
|
||
| - **Verdict**: approve | ||
| - **Diff**: `main...working-tree` | ||
| - **Axes run**: code, functional, relevancy | ||
| - **Date**: 2026_09_03 | ||
| - **Findings**: 0 critical, 0 warning, 0 minor | ||
|
|
||
| ## Phases | ||
|
|
||
| ### Phase 1 — Conflict resolution | ||
|
|
||
| - [x] One VCS skill exposes one `resolve` action — `plugins/aidd-vcs/skills/05-resolve-conflict/SKILL.md:23` | ||
| - [x] Each hunk or non-text conflict gets a choice row — `plugins/aidd-vcs/skills/05-resolve-conflict/assets/resolution-table.md:5` | ||
| - [x] An unapproved proposal changes nothing — `plugins/aidd-vcs/skills/05-resolve-conflict/actions/01-resolve.md:17` | ||
| - [x] Approved matching choices apply and stage resolved paths — `plugins/aidd-vcs/skills/05-resolve-conflict/actions/01-resolve.md:16-18` | ||
| - [x] Validation checks only resolved paths — `plugins/aidd-vcs/skills/05-resolve-conflict/actions/01-resolve.md:19` | ||
| - [x] Manifest, catalogs, and root summary expose the skill — `plugins/aidd-vcs/.claude-plugin/plugin.json:16`, `docs/CATALOG.md:87`, `README.md:243` | ||
|
|
||
| ## Findings | ||
|
|
||
| | Sev | Kind | Phase | Location | Issue | Fix | | ||
| | --- | ---- | ----- | -------- | ----- | --- | | ||
|
|
||
| ## Verification | ||
|
|
||
| | Metric | Value | | ||
| | ------ | ----- | | ||
| | Verified | 100% (6/6) | | ||
| | Files checked | `SKILL.md`, `actions/01-resolve.md`, `resolution-table.md`, plugin manifest, READMEs, catalogs | | ||
| | Unchecked | none | | ||
| | Unplanned | none | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| name: resolve-conflict | ||
| description: Resolves deterministic Git conflicts or approved choices. Use when the user wants to resolve a merge, rebase, or cherry-pick conflict. Not for deciding between competing implementations or committing changes. | ||
| argument-hint: conflict | decision | ||
| --- | ||
|
|
||
| # Resolve Conflict | ||
|
|
||
| ```mermaid | ||
| flowchart LR | ||
| start([active Git conflict]) --> resolve | ||
| resolve -->|no active conflict| none([report no conflict]) | ||
| resolve -->|all rows decided| applied([resolve and report]) | ||
| resolve -->|approval needed| proposal([propose and stop]) | ||
| proposal -->|approved table| resolve | ||
| ``` | ||
|
|
||
| ## Actions | ||
|
|
||
| Read only the next action file. | ||
|
|
||
| | Action | Does | | ||
| | ------ | ---- | | ||
| | resolve | resolve conflicts or propose choices | | ||
|
|
||
| ## Transversal rules | ||
|
|
||
| - Never commit, discard, reset, or check out changes. | ||
| - Stage only files resolved by this skill, never unrelated files. |
29 changes: 29 additions & 0 deletions
29
plugins/aidd-vcs/skills/05-resolve-conflict/actions/01-resolve.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # 01 - Resolve | ||
|
|
||
| Resolve deterministic conflicts or approved proposals. | ||
|
|
||
| ## Input | ||
|
|
||
| An active conflict, optionally with its approved decision table. | ||
|
|
||
| ## Output | ||
|
|
||
| A resolved working tree and decision table, or an unapplied proposal, formatted with [resolution table](../assets/resolution-table.md). | ||
|
|
||
| ## Process | ||
|
|
||
| 1. **Inspect.** Read the operation, unmerged paths, and conflicted hunks; if none exist, report and stop. | ||
| 2. **Decide.** Add one row per conflict to the [resolution table](../assets/resolution-table.md): matching approved rows keep their choice; identical sides keep common content; otherwise propose ours, theirs, or both with a reason. | ||
| 3. **Gate.** If a proposal lacks approval, return the unchanged table and stop; otherwise confirm approved rows still match. | ||
| 4. **Resolve.** Apply every decided row and stage the resolved paths. | ||
| 5. **Validate.** Confirm no unmerged paths and a cached whitespace check limited to resolved paths; otherwise report the failed check. | ||
|
|
||
| ## Test | ||
|
|
||
| | Case | Pass | | ||
| | ---- | ---- | | ||
| | deterministic conflict | markers are removed, Git has no unmerged paths, and rows are `Applied` | | ||
| | unapproved proposal | conflicted files and index entries stay unchanged, and rows are `Proposed` | | ||
| | approved proposal | matching choices apply, Git has no unmerged paths, and rows are `Applied` | | ||
| | unrelated staged error | resolved-path validation passes and the unrelated file stays untouched | | ||
| | no active conflict | no file or index entry changes, and the run reports no conflict | | ||
7 changes: 7 additions & 0 deletions
7
plugins/aidd-vcs/skills/05-resolve-conflict/assets/resolution-table.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Conflict resolution decisions | ||
|
|
||
| Replace the example with one row per hunk or non-text conflict. Set `Applied` only after Git validation. Remove this instruction before presenting the table. | ||
|
|
||
| | File | Conflict | Choice | Status | Reason | | ||
| | ---- | -------- | ------ | ------ | ------ | | ||
| | path | exact hunk or conflict | common content, ours, theirs, or both | Applied or Proposed | choice evidence | |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A-t-n besoin de renommer le fichier d'assets alors qu'il est nommé dans le process ?