fix: don't emit invalid "embedding" output modality (crashes TUI on startup)#30
Open
aluzed wants to merge 1 commit into
Open
fix: don't emit invalid "embedding" output modality (crashes TUI on startup)#30aluzed wants to merge 1 commit into
aluzed wants to merge 1 commit into
Conversation
OpenCode's model schema validation (tightened in recent releases, e.g.
1.16.x) only accepts text/audio/image/video/pdf as modality values.
Emitting `output: ["embedding"]` for embedding models triggers a
schema rejection (`config.get: Expected "text" | "audio" | "image" |
"video" | "pdf", got "embedding"`) that crashes the TUI on startup
("tui bootstrap failed").
Register embedding models without an explicit `modalities` field so
OpenCode applies its defaults instead of rejecting the config. Chat
models are unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After updating OpenCode (reproduced on
1.16.2), the TUI crashes on startup with:Recent OpenCode releases tightened model-config schema validation. The plugin sets
modalities.output = ["embedding"]for embedding models inenhance-config.ts, butembeddingis no longer an accepted modality value — so the whole config fails validation and OpenCode refuses to boot whenever LM Studio exposes an embedding model (e.g.text-embedding-nomic-embed-text-v1.5).Fix
Register embedding models without an explicit
modalitiesfield, letting OpenCode apply its defaults instead of rejecting the config. Chat models are unaffected. Embedding models are still discovered and counted (the "only embedding models found" guidance still works).Verification
npm run typecheck✅npm run test:run✅ (16/16)schema rejection/tui bootstrap failed, providers initialize, and chat models resolve and reach LM Studio.🤖 Generated with Claude Code