Skip to content

fix: prevent crash on empty timeout preference #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agrahn merged 1 commit into from
Jul 9, 2026
+4 −1
Merged

fix: prevent crash on empty timeout preference #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file
### Fixed

- Accidental overwriting of existing password items of same file name after editing
- Empty preference value after fresh install for PIN/biometrics expiration timeout may cause the app to crash

## [1.16.3] - 2026-04-15

Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/app/passwordstore/ui/crypto/BasePGPActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,8 @@ open class BasePGPActivity : AppCompatActivity() {
val biometrics_and_pin_last_use =
persistentPassphrases.getLong(PreferenceKeys.BIOMETRICS_AND_PIN_LAST_USE, 0L)
val biometrics_and_pin_timeout =
settings.getString(PreferenceKeys.BIOMETRICS_AND_PIN_TIMEOUT)?.toLong() ?: 3L
settings.getString(PreferenceKeys.BIOMETRICS_AND_PIN_TIMEOUT)?.toLongOrNull()
?: Constants.DEFAULT_BIOMETRICS_AND_PIN_TIMEOUT.toLong()
if (
biometrics_and_pin_timeout > 0L &&
now - biometrics_and_pin_last_use >= TimeUnit.DAYS.toMillis(biometrics_and_pin_timeout)
Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/app/passwordstore/util/settings/Constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ package app.passwordstore.util.settings

object Constants {
const val DEFAULT_DECRYPTION_TIMEOUT = 60
const val DEFAULT_BIOMETRICS_AND_PIN_TIMEOUT = 3
}