Skip to content

fix(tool): correct sessionId parameter description#2195

Open
chcodex wants to merge 1 commit into
agentscope-ai:mainfrom
chcodex:fix/session-search-tool
Open

fix(tool): correct sessionId parameter description#2195
chcodex wants to merge 1 commit into
agentscope-ai:mainfrom
chcodex:fix/session-search-tool

Conversation

@chcodex

@chcodex chcodex commented Jul 14, 2026

Copy link
Copy Markdown

Summary

  • Fix misleading parameter description in SessionSearchTool.sessionHistory(): "AgentStateStore ID""Session ID"

Test plan

  • mvn compile — passed

@chcodex chcodex requested a review from a team July 14, 2026 08:35
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AgentScopeJavaBot AgentScopeJavaBot added bug Something isn't working area/harness agentscope-harness (test/runtime support) labels Jul 14, 2026

@AgentScopeJavaBot AgentScopeJavaBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

This is a clean, minimal documentation fix that corrects a misleading @ToolParam description for the sessionId parameter in SessionSearchTool.sessionHistory(). The old description "AgentStateStore ID" was inaccurate — the parameter is semantically a session identifier, not an "AgentStateStore" identifier, as confirmed by the parameter name, usage context (workspaceManager.resolveSessionContextFile), and the surrounding code. The fix to "Session ID" is correct and consistent.

(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)

@AgentScopeJavaBot AgentScopeJavaBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

This is a clean, minimal documentation fix that corrects a misleading @ToolParam description for the sessionId parameter in SessionSearchTool.sessionHistory(). The old description "AgentStateStore ID" was inaccurate — the parameter is semantically a session identifier, not an "AgentStateStore" identifier, as confirmed by the parameter name, usage context (workspaceManager.resolveSessionContextFile), and the surrounding code. The fix to "Session ID" is correct and consistent.

(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/harness agentscope-harness (test/runtime support) bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants