doctor: exit CONFIG_ERROR when a required check fails - #456
Merged
Conversation
doctor always exited 0 regardless of what it found, so nothing could gate on it. Required checks are the readiness signals (daemon, runtime, connectivity), not the issues array, which also collects soft warnings. The structured report still reaches stdout in full. The hosted doctor adopts the same contract so the two modes cannot disagree. BREAKING CHANGE: webcmd doctor now exits 78 on an unhealthy machine.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This reverts commit 9af3317.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webcmd doctoralways exited 0 regardless of what it found — `src/doctor.ts` contains no exit-code handling and `src/cli.ts` doctor action only rendered the report. A diagnostic that reports success on an unhealthy machine can't gate an agent's next step.process.exitCode = EXIT_CODES.CONFIG_ERROR(78).Test plan
webcmd doctornow exits 78 (CONFIG_ERROR) on an unhealthy machine. Scripts that callwebcmd doctorand check$?will start seeing 78 where they saw 0. The structured JSON/YAML report on stdout is unchanged; only the exit code differs.Notes
doctor(a later PR that lands with the Cloud diagnostics endpoint) will use the same exit contract — this PR aligns local first so the two modes can't disagree.🤖 Generated with Claude Code