hosted: advertise skills and update in help + completion - #454
Merged
Conversation
Both are routed to the local program before hosted dispatch and already run under hosted configuration, but help listed skills as local-only and omitted update, and completion is derived from the advertised array so it offered neither. Drops the choose-local-mode footer from root help, where it over-claimed. The string stays on the daemon and doctor errors, where it is accurate.
Task 1 added `skills` and `update` to the advertised hosted commands and dropped the local-mode footer from root help. Two hosted test files still asserted the old shape. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. This review is advisory and does not block merging. |
This reverts commit 99a8b17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webcmd skillsandwebcmd updateare already routed to the local program before hosted dispatch (src/main.ts:78) and run under hosted configuration — verified by an existing test atsrc/hosted/main-lifecycle.test.ts:128that assertsskills addsucceeds with zero Cloud requests. But hosted root help listedskillsunderlocalOnlyCommandsand omittedupdateentirely, and hosted completion derives from the advertised array (src/completion-shared.ts:67) so it offered neither.skillsandupdateintoHOSTED_ROOT_HELP.commandsso hosted help lists them correctly and completion picks them up.daemonanddoctorerrors, where it is accurate.Test plan
Notes
🤖 Generated with Claude Code