Repository navigation
fix(release): align Python SDK release trigger with python-sdk-v* tag convention - #339
Draft
PetrefiedThunder wants to merge 1 commit into
Draft
PetrefiedThunder wants to merge 1 commit into
PetrefiedThunder wants to merge 1 commit into
Conversation
… convention The release workflow trigger pattern was python-v*, but the actual release tag followed the python-sdk-v* convention from the archived repository. This mismatch prevented the workflow from running on tagged releases. Changes: - Update workflow trigger from 'python-v*' to 'python-sdk-v*' - Update check_python_release.py to expect 'python-sdk-v' prefix - Update documentation in README.md and CHANGELOG.md to reflect the actual tag convention The trigger now matches the existing python-sdk-v0.5.0 tag and the tag convention documented in earlier releases (python-sdk-v0.4.0). Refs: #280 (receipt signing issues), evidence in uploads/amw-sbom-signing-receipts-evidence-2026-11-09.md Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Christopher <PetrefiedThunder@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
cursor Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…ronments - Change tag trigger from python-v* to python-sdk-v* to match release-python.yml convention (see PR #339) - Install Python dependencies with uv in virtual environments before scanning to capture resolved transitive dependencies - Scan installed environments (gateway and SDK Python packages) and node_modules (TypeScript SDK and site) separately, then merge into comprehensive SBOM - Update SECURITY.md to document SBOM scope: resolved Python dependencies and npm lockfiles - Note workflow is unvalidated on release tag; will verify on next python-sdk-v* release Before: 7 packages (only a few with exact pins in requirements.txt) After: Expected 50+ packages covering full dependency trees Addresses user feedback on PR #340 about thin coverage and tag pattern mismatch. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Christopher <PetrefiedThunder@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python SDK release workflow has never run because its tag trigger pattern (
python-v*) does not match the actual tagging convention (python-sdk-v*). The existing release tagpython-sdk-v0.5.0followed the convention from the archivedagent-middleware-apirepository, but the workflow was never updated to match.This PR aligns the workflow trigger and verification script with the
python-sdk-v*convention, allowing tagged releases to actually trigger the PyPI publication workflow.Related issues
Related to #280 (receipt signing issues). Evidence documented in
uploads/amw-sbom-signing-receipts-evidence-2026-11-09.md.Area and license
spec/,verifier/,sdk/python/,sdk/typescript/,integrations/, andexamples/are Apache-2.0.gateway/contributions are under FSL-1.1-ALv2 (Fair Source).Spec changes
Validation
GITHUB_EVENT_NAME=push RELEASE_TAG=python-sdk-v0.5.0 python3 .github/scripts/check_python_release.py(passes)python-v0.5.0now correctly fails validationRisk and compatibility
Changes
.github/workflows/release-python.ymltrigger frompython-v*topython-sdk-v*.github/scripts/check_python_release.pyto expectpython-sdk-vprefixsdk/python/README.mdandsdk/python/CHANGELOG.mdTag convention evidence
python-sdk-v0.5.0(Nov 5, 2026)python-sdk-v0.4.0from archived repogh run list --workflow=release-python.ymlpython-sdk-v*matches both existing and historical tagsContributor checklist