fix: report authentication failures through ACP login flow - #550
Merged
EugeneTheDev merged 1 commit intoSep 25, 2026
Merged
Conversation
EugeneTheDev
self-requested a review
September 25, 2026 13:17
EugeneTheDev
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex authentication failures now use the ACP authRequired error. The adapter does not send the error as a chat message, a session failure, or raw provider details. This also covers early, foreign, and completed-turn errors. Checks: npm run typecheck; npm run build; npm test (773 passed, 32 skipped); focused auth tests (47 passed).