Add message queue sync regression test#1740
Open
ruizanthony wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.message_queueattribute.os.path.basenamewhen serializing queued attachment names for frontend polling.Why
Queued messages can remain visually pending/spinning if
_sync_output()raises before the frontend receives updatedmessage_queueoutput data. This test locks the expected contract: queue state is read from context data and published throughset_output_data().Tests
python3 -m pytest tests/test_message_queue_sync.py -qpython3 -m py_compile helpers/message_queue.py