feat: add jwt auth for ateapi#248
Open
Eitan Yarmush (EItanya) wants to merge 1 commit into
Open
Conversation
ededf6a to
57a1ac5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #222.
Adds a portable JWT authentication path for ateapi clients while keeping the
existing mTLS mode as the default.
What changed
internal/ateapiauthwith:mtlsandjwtauth modesate-api-serverate-controlleratenet routerkubectl-ateport-forward client pathOIDC/JWKS discovery.
manifests/ate-install/jwtmanifests/ate-install/kind-jwthack/install-ate.shto opt into JWT mode with:ATE_API_AUTH_MODE=jwt--auth-mode=jwtNotes
Default install behavior remains
mtls. I think this deserves a second look as JWT will support more clusters.The JWT overlay projects short-lived ServiceAccount tokens with audience
api.ate-system.svcand mounts the service-DNS trust bundle for ateapi TLSverification.
The current discovery mechanism for JWT mode involves reading the deployment which I really don't like, but we don't have a "config file" concept so that bit is a massive TODO.
Validation