Add Skill to validate k8s CRDs.#188
Merged
Michael Taufen (mtaufen) merged 1 commit intoJun 16, 2026
Merged
Conversation
Julian Gutierrez Oschmann (juli4n)
added
area/api
Julian Gutierrez Oschmann (juli4n)
requested a review
from Michael Taufen (mtaufen)
Collaborator
|
We can add both, it's good for the agents to have an understanding of the conventions while working. |
| @@ -0,0 +1,23 @@ | |||
| --- | |||
| name: review-crds | |||
| description: Guides the agent to follow Kubernetes API conventions for OSS standards. | |||
Collaborator
There was a problem hiding this comment.
nit: "Reviews CRDs for compliance with Kubernetes API conventions" would be more tool-centric language. Whether this guides the agent depends on if the agent is triggered to open the skill.
Include a vebatim copy of the k8s conventions into the skill. I tried the skill locally and it generated a pretty decent summary of findings. I hope this will help to catch violations to the KRM style guide as we evolve our k8s APIs.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
api_conventions_skills
branch
from
5bab172 to
f640da1
Compare
Michael Taufen (mtaufen)
approved these changes
Jun 16, 2026
Michael Taufen (mtaufen)
merged commit 808806d
into
agent-substrate:main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include a verbatim copy of the k8s conventions into the skill. I tried the skill locally and it generated a pretty decent summary of findings. I hope this will help to catch violations to the KRM style guide as we evolve our k8s APIs.