Fix GNOME extension package bootstrap on Ubuntu#40
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the install.sh script to check for and install gnome-shell instead of gnome-shell-extension-tool when the gnome-extensions CLI is missing on GNOME desktop environments, and updates the corresponding warning message. The review feedback suggests allowing apt-get update to fail gracefully with a warning instead of aborting the script, which improves the resilience of the installation process.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Clarification after checking Ubuntu 26.04 apt metadata:
The installer needs the The package that failed in the installer, |
avifenesh
left a comment
There was a problem hiding this comment.
Looks good. I validated this against the current Ubuntu 26.04 package state: the failing package name is not installable, while gnome-shell provides the gnome-extensions CLI the installer actually needs. The apt/GNOME branch behaves correctly in mocked installer runs, and local validation passed. The apt-get update resilience suggestion is pre-existing installer hardening, not a blocker for this fix.
|
@timrichardson Thanks a lot! |
Fixes #39
Summary
gnome-shell-extension-toolapt package on GNOMEgnome-shellonly whengnome-extensionsis missing and apt can provide itVerification
bash -n install.shgit diff --check./install.sh --skip-system-deps --skip-doctor