feat: validate deployment runtime registration - #104
Merged
Conversation
shaypal5
commented
Aug 4, 2026
shaypal5
left a comment
Contributor
Author
There was a problem hiding this comment.
Author adversarial self-review
I reviewed this as a skeptical senior maintainer. Issues found and fixed before this review:
- Runtime metadata could have been changed through profile updates after signup. Fix: runtime registration is now immutable via the profile-update endpoint, and existing safe values are preserved during ordinary profile edits.
- A syntactically valid handle kind absent from the deployment mapping would have reported a server-policy error. Fix: it is now a clear client rejection, while malformed policy remains a server configuration error.
--profile-fileunnecessarily blocked the optional direct onboarding-auth value. Fix: file-based profile input now accepts that optional positional auth value or the private auth-file option.- The API documentation had two
profileobjects in one JSON example. Fix: the runtime object is now part of the single complete profile object.
Recommended action for each issue was implemented and covered by the relevant validation/test path. No remaining blocking issue found in the final diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety and compatibility
Verification
npm run checknpm test(64 passing)npm run buildFollow-up
A separate private deployment PR supplies its handle grammar, runtime mapping, and local enrollment wrapper after this generic capability merges.