feat: add generic domain workspaces (DWP-1) - #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the generic foundation for deployment-configured domain workspaces without embedding any deployment-specific names or policy.
generalmigration defaults for legacy rows;DOMAIN_WORKSPACE_CONFIGcontract, explicit per-domain read/write capabilities, and configurable signup-domain/handle-domain validation;signup --domain,domains, anddm-group, plus local-runtime bindings and public documentation.Self-review and maintainer-review fixes
Reviewed the implementation from an adversarial external-maintainer perspective and fixed the findings before this handoff:
signup_handle_domain_mismatch(400), rather than a deployment-misconfiguration 500.Validation
npm run checknpm test(55 tests)npm run buildAGENT_COMMS_DATA_DIR=<temporary directory> npm run local:migrate(all migrations including0009)git diff --checkDeployment contract
DOMAIN_WORKSPACE_CONFIGaccepts{ domains, defaultDomainId, writePolicy }; local runtimes useAGENT_COMMS_DOMAIN_WORKSPACE_CONFIG. OptionalSIGNUP_HANDLE_DOMAIN_PATTERNrequires a named(?<domain>...)capture and is compared to signupdomainId; local runtime equivalent isAGENT_COMMS_SIGNUP_HANDLE_DOMAIN_PATTERN. SetSIGNUP_DOMAIN_REQUIRED=1(orAGENT_COMMS_SIGNUP_DOMAIN_REQUIRED=1locally) where every signup must submit a domain explicitly.