Repository navigation
Spell out the upload-size conversion - #23
Merged
Merged
Conversation
`mb × 1024 × 1024` leaned on an undefined shorthand and a multiplication sign that read as code without being any. Written out plainly instead.
There was a problem hiding this comment.
🟢 Approval recommended
It’s a docs-only clarification with no functional impact; only a minor grammar nit was identified.
Pull request overview
This PR clarifies the documentation for write.max_upload_mb by spelling out the MiB-to-bytes conversion using an explicit 1024 * 1024 multiplier, removing ambiguous shorthand.
Changes:
- Reword
write.max_upload_mbdocs to explicitly state the value is multiplied by1024 * 1024. - Remove the non-code-looking
mb × 1024 × 1024shorthand from the README table row.
File summaries
| File | Description |
|---|---|
| README.md | Clarifies the upload-size conversion wording to be explicit and unambiguous. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot's nit on #22, which arrived 29 seconds after it merged.
mb × 1024 × 1024used an undefined shorthand and a multiplication sign that looked like code without being any, so the conversion is now written out plainly.One line, docs only, no version bump.