sync: consume the studio's example-expansion governance into the canonical Astryx contract#22
Merged
Merged
Conversation
…nical Astryx contract One-time studio -> dspack catch-up (PHASE-NEXT P0 in dspack-studio): the example-expansion milestone authored owner-approved governance in the studio's byte-copy through reviewed PRs (dspack-studio #17, #18, #19, #20) while this canonical copy stayed at the 3-intent, 9-component edition. This commit restores byte equality by consuming that content: - intents: record-collection, data-collection, transactional-review - components: list, selectable-card, metadata-list (upstream-faithful; metadata-list items are data-props with a documented x-drift note) - rules: 9 new intent-scoped rules; the table rule's choice-set caveat revised to what current rule types can express - examples: ex.support-ticket-triage, ex.signup-basic, ex.plan-comparison - table columns/data gain required:true (the dspack-gen 0.1.2 grammar mechanism; this repo's 0ea1ac2 already typed the item shapes) Verified superset: no upstream-only content is lost (the studio copy differs on shared content only by the two required flags). Steady state after this commit is upstream-first: canonical changes land here, the studio consumes byte-identical copies, and both repos' sync checks stay green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the canonical Astryx dspack contract with the studio’s expanded governance/content, restoring byte-equality by bringing over additional intents, components, rules, and worked examples (plus marking table columns/data as required in prop descriptors).
Changes:
- Mark
table.columnsandtable.dataprop descriptors asrequired: true. - Add three components (
list,selectable-card,metadata-list) and three intents (record-collection,data-collection,transactional-review) with intent-scoped governance rules. - Add three new worked examples aligned to the new intents.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "props": { | ||
| "type": "body" | ||
| }, | ||
| "text": "Name and email is all it takes. You can add the rest later." |
| ], | ||
| "x-source": "https://github.com/facebook/astryx/blob/v0.1.4/packages/core/src/List/List.doc.mjs", | ||
| "composition": { | ||
| "notes": "Takes arbitrary children (ReactNode); surfaces express items as child nodes — for a comparison, selectable-card children." |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-time studio → dspack catch-up (PHASE-NEXT P0 in dspack-studio). The example-expansion milestone authored owner-approved governance in the studio's byte-copy through reviewed PRs (dspack-studio #17–#20) while this canonical copy stayed at the 3-intent / 9-component edition. This PR restores byte equality by consuming that content:
record-collection,data-collection,transactional-reviewlist,selectable-card,metadata-list(upstream-faithful projections; metadata-list's data-propsitemscarry a documentedx-driftnote)ex.support-ticket-triage,ex.signup-basic,ex.plan-comparisoncolumns/datagainrequired: true(the dspack-gen 0.1.2 grammar mechanism; this repo's 0ea1ac2 already typed the item shapes)Verified superset against pre-sync main (including the just-merged structured-editing work): no upstream-only rules, examples, or components are lost; the only shared-content delta is the two
requiredflags.Steady state after this merge is upstream-first: canonical changes land here, dspack-studio consumes byte-identical copies, and sync checks stay green in both repos (dspack-studio gains
check:syncin its P0 PR; dspack-gen's existing check-sync will flag its fixture for re-sync — the follow-up PR there is queued).🤖 Generated with Claude Code